Issue 846 better syntax for annotated paragraph #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ducasse
reviewed
Aug 20, 2024
| ifNotNil: [ body = '' ifTrue: [ body := body , line ] | ||
| ifFalse: [ body := body , String cr , line ]] | ||
| | indexOfFirstClosingBracket | | ||
| indexOfFirstClosingBracket := line indexOf: $]. |
There was a problem hiding this comment.
I wonder what is the impact if the line does not contain ]
There was a problem hiding this comment.
After getting the index of the first ], I test if he egal to 0.
If true, I removed the AnnotatedParagraphe to MicRootBlock, and I replace by a MicBlockQuoteBlock
indexOfFirstClosingBracket = 0
ifTrue: [ parent children removeLast. ^ self createMicBlockQuoteBlock: line ]
Ducasse
reviewed
Aug 20, 2024
| @@ -25,12 +26,39 @@ MicAnnotatedParagraphTest >> testBasicAnnotetedParagraph [ | |||
| equals: 'This is an important information' | |||
| ] | |||
|
|
|||
| { #category : 'tests' } | |||
| MicAnnotatedParagraphTest >> testBasicAnnotetedParagraphIgnoreExtraTextInFirstLine [ | |||
Ducasse
reviewed
Aug 20, 2024
| @@ -41,6 +45,22 @@ MicAbstractAnnotatedBlock >> canConsumeLine: line [ | |||
| ^ line isNotEmpty | |||
| ] | |||
|
|
|||
| { #category : 'as yet unclassified' } | |||
There was a problem hiding this comment.
could categorize the method.
|
The following tests are not passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #846
I change the !! syntax to >[!