Handle errors due to unavailable CSS frameworks #694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernanmd
force-pushed
the
fix_css_download_errors
branch
from
fdde9e7
to
577ace6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handle errors due to unavailable CSS frameworks by skipping the download and reporting the error to the Transcript (issue #693)
(Note: Inadvertently, in Pharo 12, all Symbol specifying
categoryand class names were replaced by String. I don't know how to prevent this or send it in another PR since Iceberg doesn't list the changes if there are no changes :)If anyone knows, please let me know).
A second PR will prevent the listing of the CSS framework in the UI.