Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MERGE ME - Inline rewrite all green #626

Merged
merged 44 commits into from
Jan 7, 2024

Conversation

kasperosterbye
Copy link
Collaborator

No description provided.

@kasperosterbye
Copy link
Collaborator Author

@Ducasse
Current status now is

  • that the inline compiler is rewritten
  • all tests are green
  • All API usage in RichText, Latex, and HTML has been updated (children and bodystring only)
  • Added support for inline http and https (just to test if the compiler was as flexible as I wanted)
  • Added support for github style bold __this is bold__ and italics *this is italic* in addition to the existing ways (just to test that there can be more than one syntax)
  • Beautiful comments is unaffected

Missing:

  • I presume Macrodown (Estebans version) will break as his extension is based on extending the old inline compiler
  • I would expect that some of Beamer, Agenda etc will break as the API has been restricted and is more consisten

My plan is to try to load all classes in Microdown and fix all tests before this PR should be included in dev.

  • I will give a ping when it is done.
  • But if you want to read code - now there is plenty 😀

@kasperosterbye kasperosterbye changed the title Inline rewrite all green DO NOT MERGE Inline rewrite all green Nov 6, 2022
@kasperosterbye kasperosterbye changed the title DO NOT MERGE - Inline rewrite test Inline rewrite all green Nov 6, 2022
@Ducasse
Copy link
Contributor

Ducasse commented Nov 6, 2022

Thanks for the update.
I'm chasing a bug and I should do one xp for a student and I will have a look. So probably in the evening.

@kasperosterbye
Copy link
Collaborator Author

@Ducasse
There are two different kinds of inconsistencies with the old inline parser and old inline parser blocks

  1. The previous blocks had several methods for accessing the original source code. That was used in two different situations. a) As a lazy way to do tests (avoiding to dive into the AST for validating), and b) several places used those source methods mistakingly (missing visits to children). I have in general changed both a) and b) to behave correctly.

  2. The new parser has a different algorithm for parsing. Hence Macrodown which extended the old algorithm will not work. It is the only case I know of where the inline parser algorithm was extended. I will not fix this.

I tried Agenda, which works fine.
I do not expect this to break your book making, but I obviously have not tried. Latex translation might have a issues in category 1. above.

I will not do anything more on this one now, I considerer it working except for the risk of a few issues in category 1 which so far has been easy for me to fix.

@Ducasse
Copy link
Contributor

Ducasse commented Nov 7, 2022

Ok I will check. I was removing root trees today.... and now meeting with the town.
but I'm reducing my todo list.

@kasperosterbye kasperosterbye changed the title DO NOT MERGE Inline rewrite all green MERGE ME - Inline rewrite all green Nov 14, 2022
@Ducasse
Copy link
Contributor

Ducasse commented Nov 22, 2022

Hi kasper
Why did you close this PR?
This was still on my todo list

@Ducasse Ducasse mentioned this pull request Nov 22, 2022
@kasperosterbye
Copy link
Collaborator Author

OK, I really want your input on this. It is massive and invasive.

@Ducasse
Copy link
Contributor

Ducasse commented Nov 22, 2022

I will.
Now I would like to finish to release (get a working master in BC, Document Browser and MD) Not talking about integration.
But I'm busy teaching two times more lectures for yet another week and it will be back to normal.

@Ducasse Ducasse merged commit 9dc52bd into pillar-markup:dev Jan 7, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants