Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

fixed editor ids, fixes pilat/vscode-coverage-highlighter#24 #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AlexHaxe
Copy link

@AlexHaxe AlexHaxe commented Jun 3, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@0187987). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head a98fb27 differs from pull request most recent head 306b226. Consider uploading reports for the commit 306b226 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master      #26   +/-   ##
=========================================
  Coverage          ?   95.37%           
=========================================
  Files             ?       25           
  Lines             ?      972           
  Branches          ?      152           
=========================================
  Hits              ?      927           
  Misses            ?       45           
  Partials          ?        0           
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/providerManager.ts 96.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0187987...306b226. Read the comment docs.

@AlexHaxe
Copy link
Author

This also needs a change on line 56 of the providerManager, not only to update the id to the uri but also to check whether an editor was passed in.

updated, thanks for checking!

@rfunk
Copy link

rfunk commented Jun 23, 2021

Good update, now it works for me.
Well, mostly: There's still something wrong with the initialization, where the initially-active editor doesn't get its percentage updated in the status bar until changing away from it and back to it. But that's minor compared to the original problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants