Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GREY pixelformat #171

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Conversation

gudvinr
Copy link
Contributor

@gudvinr gudvinr commented Sep 10, 2022

Fixes #170

Monochrome cameras send only Y component of YUV image

@gudvinr
Copy link
Contributor Author

gudvinr commented Sep 10, 2022

I think that instead of writing same luma value into RGB components it might be beneficial to just use JCS_GRAYSCALE and encode into 8-bit image instead to save size but I am not sure how it would work here.

@mdevaev mdevaev force-pushed the master branch 6 times, most recently from b6fc13b to ef47fa4 Compare March 2, 2024 23:04
@mdevaev mdevaev force-pushed the master branch 2 times, most recently from 677fbbf to e558b0f Compare March 5, 2024 12:20
@mdevaev mdevaev force-pushed the master branch 4 times, most recently from 6e85e11 to 1803879 Compare April 5, 2024 16:21
@gudvinr gudvinr force-pushed the feature/170_grey_pixelformat branch 2 times, most recently from aaaf1b5 to e00a184 Compare March 7, 2025 08:41
@gudvinr
Copy link
Contributor Author

gudvinr commented Mar 7, 2025

@drowningblue can you please test this PR?

@mdevaev can you review this PR? I rebased on top of latest release.

@mdevaev
Copy link
Member

mdevaev commented Mar 7, 2025

Looks fine for me, just replace type names. And we need a testing.

@drowningblue
Copy link

drowningblue commented Mar 7, 2025

Sorry it took me awhile, I am a total noob here. But it is working, thank you. I have a stream!

One small thing to note is GREY under formats is missing in --help

Thank you both again! @gudvinr @mdevaev

Fixes pikvm#170

Monochrome cameras send only Y component of YUV image
@gudvinr gudvinr force-pushed the feature/170_grey_pixelformat branch from e00a184 to 01b3335 Compare March 8, 2025 13:15
@gudvinr
Copy link
Contributor Author

gudvinr commented Mar 8, 2025

Looks fine for me, just replace type names.

Done.

It works with my oCam, I see the stream.

@gudvinr
Copy link
Contributor Author

gudvinr commented Mar 8, 2025

@mdevaev I doubt you have a camera that can output GREY but I think v4l2loopback can do this, so if you want or need to verify it yourself before pulling, it might be a good choice.

@mdevaev
Copy link
Member

mdevaev commented Mar 8, 2025

@gudvinr I believe you :D

@mdevaev mdevaev merged commit b380beb into pikvm:master Mar 8, 2025
gudvinr added a commit to gudvinr/ustreamer that referenced this pull request Mar 8, 2025
Follow up to pikvm#171. Forgot to add GREY to docs.
@gudvinr
Copy link
Contributor Author

gudvinr commented Mar 8, 2025

Forgot to update docs, you can cherry pick 7e861ef

@mdevaev
Copy link
Member

mdevaev commented Mar 9, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support monochrome cameras
3 participants