-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs for 0.3 (fix #51) + changelog + make it nim v2.0 compatible #56
Conversation
Seems like you are using the |
damn you are good! I was trying indeed to understand what went wrong! I should have fixed it now, let's see. |
not sure why this is still hanging here, my bad, will try to look a this. also #51 has a bunch of tasks I listed back then and not sure if they are covered by this (which is essentially just adding a changelog and making sure we use nimib 0.3 - which is now probably outdated already - we should use latest stable... |
Yes it would be nice if we could get nimibook 0.3 released soon, so we can focus fully on the SSG + nimib org in the coming months. I will try and get pietroppeter/nimib#163 done this week, so we can merge #61 as soon as possible as well. Is there anything else code-wise that has to be done, or was stabilizing the parallel build the final thing? |
No, I do not recall anything code wise that needed to be done. It was mostly documenting all the changes the went through the refactoring. For the async thing at the time the idea was to disable, now there is no need to do it. |
Does #61 depends on that nimib code thing? |
Ok, that's good 👌 |
I added the parallel out.js fix to that PR 🙃 could have done it in a separate PR of course... But I just have to go through all the existing nimib documents again and confirm nothing has been broken by it. (When you have to read through all of scinim/getting-started you realize that we have quite a bit of material there 🤣) |
ah ok right, you mentioned that |
If I don't find any bugs in it, I should be able to have it done tomorrow evening. And then I should have #61 done on saturday. Just in time before the speaking hours 😎 |
wait the error in tests I see is due to the out.js and is the one that will be fixed? |
Yes I think so, it's hard to tell without seeing the log file though 😛 I think we are always compiling a js file even if no nbJs is used, but I fixed that one as well in the nimib PR. Hence the error here even if we don't use nbJs |
I see that if I run multiple times |
Because I never added a check to see if we actually wrote any nbJs code. So it just compiles an empty |
anyway now I remember what this PR was about, documentation on how to use nimibook needs to be improved substantially. things changed in last refactoring and they are not documented anywhere (except in the code) |
finally this PR is ready to be merged! @HugoGranstrom do you want to give a quick look before I merge and tag 0.3 release? I did change substantially the documentation that now reflects the current state of nimibook.
see first PR message for all the details (I kept it up to date). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on cleaning up and writing documentation! 😄
I didn't find anything major, just a few link-related comments that needs to be fixed and a very picky comment on the Latex part :)
Co-authored-by: Hugo Granström <[email protected]>
Co-authored-by: Hugo Granström <[email protected]>
Co-authored-by: Hugo Granström <[email protected]>
Thanks! Will wait for CI to finish and merge after giving another look at the preview. |
improve documentation
additional improvements of this PR:
created changelog complete with history of 0.1 and 0.2 + updates on 0.3:
create (or link) issues for other improvements to do in next versions:
edit: this first PR message was multiple times edited (in particular adding todo points from #51)
to keep it up to date with PR content. The discussion below might reflect an earlier version of this ,message.