Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move css, fonts, js to assets folder; auto install assets folder #19
move css, fonts, js to assets folder; auto install assets folder #19
Changes from 12 commits
f3dcc4e
a679fad
5ce2987
0153d31
9a81634
0730ff2
1684fb3
09c4f6e
8ea9369
b7b8afb
37e8818
0fdd3b5
357be94
69e93f0
1f098b7
f004e8d
3815211
04dfae4
778fc24
3796311
8301864
31b0818
27c16e1
b3096f2
ed039b3
e70e18a
ec91fa6
2b2ee31
7dd8428
cf86eaa
549efed
72a79ff
3f8bbb4
1e2b356
46e685a
8e1b67d
3845ccb
a34fa4b
9256b48
4a11ff6
9acda49
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
templates are staying in book folder? I thought we were moving them to a templates but maybe that was an assumption I made in my head and never shared... :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we misunderstood each other. My idea was to have a
ressources/template
folder insrc/nimibook
to deploy the mustache files automatically in the book folder (per the init mechanism we discussed)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this comment I describe an alternative folder structure. Do you think it could be done in this PR? if not we can do it/discuss it later. If it stays like this maybe I would just change
ressources
toresources
:)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, you want to have the whole book structure in
src/nimibook/theme
and copy it in the current folder upon calling theinit
/update
step ?That is perfectly do-able, I don't think we even need a config.nims to test it (Init should do the trick). We can just copy "*.mustache" from
templates
into rootfolder (currentlybook
comes from user input so we can't use it intheme
).Just one question : why keep
docs/assets
instead of justæssets
copied intodocs
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do and discuss this in another PR :)