don't re-panic if the io.Writer returns an error

pierrre · Aug 5, 2024 · 8b8957f · 8b8957f
1 parent f5facc7
commit 8b8957f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/pretty.go b/pretty.go
@@ -165,16 +165,16 @@ func (c *Config) checkRecover(w io.Writer, r any) {
 	if r == nil {
 		return
 	}
-	WriteString(w, "<panic>: ")
+	_, _ = writeString(w, "<panic>: ")
 	switch r := r.(type) {
 	case string:
-		WriteString(w, r)
+		_, _ = writeString(w, r)
 	case error:
-		WriteString(w, r.Error())
+		_, _ = writeString(w, r.Error())
 	default:
-		noErrorWrite(fmt.Fprint(w, r))
+		_, _ = fmt.Fprint(w, r)
 	}
-	WriteString(w, "\n")
+	_, _ = writeString(w, "\n")
 }
 
 func (c *Config) checkValid(w io.Writer, v reflect.Value) bool {

diff --git a/pretty_test.go b/pretty_test.go
@@ -550,6 +550,12 @@ func TestConfig(t *testing.T) {
 	}
 }
 
+func TestConfigPanicWriterError(t *testing.T) {
+	c := newTestConfig()
+	w := &testErrorWriter{}
+	c.Write(w, "test")
+}
+
 func BenchmarkConfig(b *testing.B) {
 	for _, tc := range testCases {
 		b.Run(tc.name, func(b *testing.B) {