Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumb the minimal MDAnalysis version required #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbarnoud
Copy link
Collaborator

We were asking for MDAnalysis >= 0.11, but that version is ancient and
the API changed rather drastically since then. I bumped the minimum
required version to 0.16. The tests run fine with version 0.17 that
should be preferred, especially on python 3.

@HubLot I do not know what should be done for the conda package to be rebuilt. It should now be possible to install PBxplore on python 3 with conda as MDAnalysis was the last obstacle.

We were asking for MDAnalysis >= 0.11, but that version is ancient and
the API changed rather drastically since then. I bumped the minimum
required version to 0.16. The tests run fine with version 0.17 that
should be preferred, especially on python 3.
@pierrepo
Copy link
Owner

I totally agree. We need to push toward the use of a recent version or mdanalysis.

@HubLot for conda. Could we create a quick recipe to build the package upon bioconda? This looks like the standard for bioinformatics tools.

@HubLot
Copy link
Collaborator

HubLot commented Feb 12, 2018

It's doable now since MDAnalysis is already in a conda channel. I think @jbarnoud's modifications are enough to create a conda package in a custom channel. If it succeeds, yes, we can offer a recipe for bioconda.

I can look into it next week.

@pierrepo
Copy link
Owner

modifications are enough to create a conda package in a custom channel.

@HubLot instead of creating our own custom conda channel, could we join bioconda channel? Their build process seems pretty robust (https://bioconda.github.io/contributing.html)?

@HubLot
Copy link
Collaborator

HubLot commented Feb 12, 2018

Yes, it is the main objective. I just wanted to try the build first before submitting to bioconda.

@pierrepo
Copy link
Owner

OK, as you wish. But the build process proposed by Bioconda is pretty safe (everything is build upon Travis)

@jbarnoud
Copy link
Collaborator Author

jbarnoud commented Feb 12, 2018 via email

@HubLot
Copy link
Collaborator

HubLot commented Feb 20, 2018

So, I retried to build a conda package from the command line but now it fails... (either on the master or this PR branch) :

see this gist: https://gist.github.com/HubLot/18da1e2063001a1a51c73916ab4adff7

It seems it's an issue on Pytest but I'm not sure. I'll try to dig more into it but I'm quite busy in the next 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants