Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window OnLoadComplete and GetPreferredSize improvements #2684

Merged

Conversation

cwensley
Copy link
Member

  • OnLoadComplete is now called by Window handler implementations at the appropriate time
  • Window.GetPrerredSize() should now be guaranteed to work for a Window during the LoadComplete event on all platforms, and for some platforms before it is shown.
  • Gtk still has issues including the window decorations with the preferred size, work is ongoing there.
  • Mac now calls Window.Shown after children get the same event, like other platforms.

- OnLoadComplete is now called by Window handler implementations at the appropriate time
- Window.GetPrerredSize() should now be guaranteed to work for a Window during the LoadComplete event on all platforms, and for some platforms before it is shown.
- Gtk still has issues including the window decorations with the preferred size, work is ongoing there.
- Mac now calls Window.Shown after children get the same event, like other platforms.
@cwensley cwensley added this to the 2.8.4 milestone Sep 23, 2024
@cwensley cwensley merged commit 550d37a into picoe:develop Sep 23, 2024
3 checks passed
@cwensley cwensley deleted the curtis/loadcomplete-and-getpreferredsize branch September 23, 2024 21:15
@cwensley cwensley mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant