Mac: Fix some events not firing properly #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, especially when the object being attached such as an
NSScrollView.ContentViewgets GC'd before it gets a chance to register, it would fail causing scroll events to not fire. This is because we were (incorrectly) usingRuntime.TryGetNSObject()which will only return an object if it still has a managed instance.Additionally if we were to add an event after the control is loaded it wouldn't register it properly so we only delay registration before it has been loaded.
Now we use
Runtime.GetNSObject()so it'll create an instance if necessary.This issue was caused by #2654 as now we only add notification centre observers when the control is loaded, giving more time for the .NET instance to be GC'd if it isn't referenced anywhere.