Mac: Fix universal binary build #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aha! Great find, thanks for digging into that and fixing the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My MacOS universal binary builds were corrupted when the C# project name contained some combination of letters. I went digging in and found the culprit. The
TrimStart()method does not trim the specified parameter from the string start, but actually trims as much chars from the front of the string as possible as long as the given parameter contains all those chars (reference). This is used to trim the leading relative path of a file, so as a consequence the path gets corrupted.For example, if my project name was
MYPROJECTtrimmingbin/Debug/net6.0/osx-arm64/MYPROJECT.app/frombin/Debug/net6.0/osx-arm64/MYPROJECT.app/Contents/MacOS/MYPROJECTwould result in a corrupted path ofcOS/MYPROJECTinstead of the expectedContents/MacOS/MYPROJECT. Then my universal binaryMYPROJECT.appwould actually contain a subdirectorycOSwithMYPROJECTbinary.