-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pylance fixes #906
Pylance fixes #906
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #906 +/- ##
==========================================
- Coverage 89.27% 88.41% -0.86%
==========================================
Files 114 114
Lines 8333 8383 +50
==========================================
- Hits 7439 7412 -27
- Misses 894 971 +77 ☔ View full report in Codecov by Sentry. |
allow it to receive a function which returns a `time` value
It can accept a function which returns a `date` value
This PR is insanely big - I'm going to break it down into smaller chunks, and merge those in (starting with any changes to test files). |
Builds on the changes in PR #905
Similarly to Mypy, Pylance has become much stricter / more accurate over time. There are now quite a few minor type errors being reported by Pylance.
As VSCode is such a popular code editor it would be good to clean up most (if not all) of these minor errors.
I'm not sure how easy it is to add Pyright (which powers Pylance) as a linter to our CI, but will investigate.