Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional note position #285

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hscheewel
Copy link

Hi everyone,
I've added an additional checkbox to the preferences dialogue that toggles the orientation of the small blue bar (the one that indicates the position of the played key). This way the user can choose between getting hints on the position of the note that he/she just played or not..
If you consider this a useful feature, feel free to merge, edit or point out mistakes.
Ah, and I added the ncurses library to the CMakeLists.txt since I was not able to build the app on Ubuntu 20.04 without it..
Best,
Hendrik

@louis-barman
Copy link
Collaborator

Ok Thanks for this. I have had in the back of mind to add various challenges to PB to make it harder. Like playing a piece in different tempos and transpose it to different keys. One extra hard challenge is completely to blank the screen forcing the user to either play from memory or read from a printed musical score. PB is all about helping users mastering to read sheet music. So this would be a another challenge that we could get users to do. So I would recommend that you move the enabling "Show Note Position" to a new dialog called Challenges and rename it to "Hide Note Position Challenge". With a button start challenge. I don't think challenges should be remembered incase they accidentally get left on.

I don't really want this added as it is to the develop branch at the moment in case a user accidentally selects this option and then does not know how to recover from the situation. I would however accept this code into a new challenges branch without you making more changes if you don't want to make these changes I suggested above.

Let me know what you want to do and then i'll review the code (although I am very busy with other things at the moment).

Also there are lots of other things you could work on if you are interested. Like showing a percentage score at the end of playing a song. Years ago i created GuiHighScoreWindow.ui but that is far as I got . A percentage score could be created from detecting and counting up all the right and wrongs notes played. I think the GuiHighScoreWindow.ui should be renamed to something like GuiSkillLevelResults.ui

@hscheewel
Copy link
Author

Hi! That's a good idea! I'll work on a new PR as soon as I find some time for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants