fix path to cert file into dynamic value #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e independent of the current running dir
|
I guess this solved the bug where the user runs the scripts from another folder and the scripts can not find the CA file. Please confirm this is the case, and we will run some QA on this PR and approve it. |
|
In short : Yes that is the case ! And solved other situations relative to the situation when we use scripts independently (running get_token alone or port_forwarding alone) from whatever current running directory is, |
|
Sorry for the long wait time. I think the common practice for the variable name is |
|
CAPS characters is for global variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cert file path must be dynamicly computed into absolute path to be independent of the current running dir