Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add 3rd party client: milahu/vpn-client-pia-wireguard-posix-shell #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

milahu
Copy link

@milahu milahu commented Nov 3, 2021

add my client vpn-client-pia-wireguard-posix-shell to readme

using this on my laptop, which is running 24/7 ... no crashes so far : )

could be slightly useful for writing an openwrt backend,
since openwrt has only sh, no bash

... but wg-quick is written in bash.
there is wg-quick.posix.sh by Rowan Thorpe (ported from wg-quick),
but 1. its buggy, and 2. openwrt has the uci interface for editing the config (iptables, etc)

@g00nix
Copy link
Contributor

g00nix commented Dec 28, 2021

I will read through this before adding it to the readme. Looks really cool at the first glance.

@milahu
Copy link
Author

milahu commented Dec 28, 2021

looks good on paper ; )

there is a bug in wg-quick.posix.sh
so currently, this is not a pure posix-shell client, but still needs bash

@g00nix
Copy link
Contributor

g00nix commented Feb 19, 2022

@milahu I started reading and I found this. Do you think you can find a better solution?

@milahu
Copy link
Author

milahu commented Feb 19, 2022

that's dead code in the if false; then ... fi block

its a draft for openWRT backend, using uci commands
of course, the config vars like network.pia.private_key should be in the config file

the actual code is using config_file and default_config_file to store the config

@g00nix
Copy link
Contributor

g00nix commented Feb 19, 2022

Private keys should not be present anywhere in the repo and should always be generated. Even if you don't use that private key and it's just there as an example, it sill looks weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants