Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove >domain from Telnet API #914

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Remove >domain from Telnet API #914

merged 1 commit into from
Sep 13, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Aug 26, 2023

What does this PR aim to accomplish?:

Removes outdated Telnet API endpoint from the docs. Fixes #913

pi-hole/FTL@3a4d8e2 removed the >domain endpoint.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@netlify
Copy link

netlify bot commented Aug 26, 2023

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 6a8a9c7
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/6500d23e402f3c00083c1b2d
😎 Deploy Preview https://deploy-preview-914--pihole-docs.netlify.app/ftldns/telnet-api
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Christian König <[email protected]>
@yubiuser yubiuser merged commit 35acfe9 into master Sep 13, 2023
11 checks passed
@yubiuser yubiuser deleted the no_domain branch September 13, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

>domain command no longer in FTL but still contained in telnet api page
2 participants