Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unbound.md #908

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Update unbound.md #908

merged 2 commits into from
Aug 5, 2023

Conversation

clwgh
Copy link
Member

@clwgh clwgh commented Aug 5, 2023

What does this PR aim to accomplish?:

Minor tweak to logfile section to ensure human-readable timestamps (default is Unix time)

How does this PR accomplish the above?:

Include an additional config line and updated description in the logfile section

Link documentation PRs if any are needed to support this PR:
n/a


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Minor tweak to logfile section to ensure human-readable timestamps (default is Unix time)

Signed-off-by: Chris L <[email protected]>
@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit d68e701
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/64cdf36b7089540008d9d496
😎 Deploy Preview https://deploy-preview-908--pihole-docs.netlify.app/guides/dns/unbound
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option log-time-ascii is around since at least Unbound 1.4.21 (back in 2013) so no compatibility issues are expected.

@DL6ER DL6ER merged commit 13cb7d5 into pi-hole:master Aug 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants