Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve regex documentation #1204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve regex documentation #1204

wants to merge 2 commits into from

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 10, 2025

What does this implement/fix?

Clarify how character classes need to be specified and explain how they can be combined with other selectors in character groups.

Related issue or feature (if applicable): Fixes pi-hole/FTL#2364

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…ey can be combined with other selectors in character groups.

Signed-off-by: DL6ER <[email protected]>
Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit b9eff53
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/67cf4d472bd8a7000810b712
😎 Deploy Preview https://deploy-preview-1204--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: yubiuser <[email protected]>
Signed-off-by: Dominik <[email protected]>
@DL6ER DL6ER requested a review from yubiuser March 10, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Character classes regex do not match their group equivalents
2 participants