-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Netlify CI variables in netlify.toml #1194
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Are there any site environment variables set in Netlify's UI? Because it's still using Python 3.8 |
yeah, it was set to 3.8. Have changed it to 3.12 - try again! |
Thanks. With the second commit I've set it via I think I prefer to set it via config file instead of having it in the Netlify UI - It's easier to keep it up-to-date and not forget about it. |
If you are going with this, I suggest that you move all env vars and settings in runtime.txt and remove them from Netlify UI. That way everything will be handled in one place. Other settings are Node version, build command, folder and maybe more. |
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
I added all other environment variables defined in Netlify's UI to the |
How about build command and directory? Also, will your settings work for branch deployments? I notice you used |
…and deploy-preview Signed-off-by: yubiuser <[email protected]>
Can squash down when desired |
See also https://docs.netlify.com/configure-builds/file-based-configuration/#build-settings Both |
What does this PR aim to accomplish?:
We just switched to Ubuntu Noble 24.04 which uses an up-to-date python (3.12) by default. See #1189 (comment)
By submitting this pull request, I confirm the following:
git rebase
)