-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump alpine to 3.20 #1621
Bump alpine to 3.20 #1621
Conversation
Do you want also upgrade here? |
81e589f
to
e7c99e6
Compare
FP'd |
e7c99e6
to
1c6c1b3
Compare
Signed-off-by: Adam Warner <[email protected]>
Perhaps not as simple as that... one to investigate |
I tried to build and test locally and I'm receiving this error:
|
Signed-off-by: yubiuser <[email protected]>
Another approach would be to remove the |
See my commit and last comment. Which way do you prefer? |
Ah, Sorry - didn't see that you'd pushed a commit before your comment. If I've understood it correctly, I think the monkeypatch is probably more resiliant as it is one less thing to have to update every time the python version updates? |
Signed-off-by: yubiuser <[email protected]>
I think I found a nice solution. My concern with the monkeypatch is that it is way harder to understand than a small sed command |
Ah yeah, that's good! |
What does this PR aim to accomplish?:
Update Alpine base from 3.19 to 3.20
By submitting this pull request, I confirm the following:
git rebase
)