Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of PIHOLE_DOCKER_TAG in dockerfile #1584

Closed
wants to merge 0 commits into from

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

The update checker script from the core repo expects the docker tag to match a specific regex (see: https://regex101.com/r/RsENuz/1)

This prepends the default with dev- so that it is populated correctly:

image

Also adds a options to build.sh to customise the DOCKER_BUILD_VERSION and PADD_BRANCH build args


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

build.sh Outdated Show resolved Hide resolved
@PromoFaux
Copy link
Member Author

Broke this with a fp :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants