Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add the PIHOLE_DOCKER_TAG build arg that went missing along the way #1395

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

While we still use pihole -v and pihole updatechecker (these may be removed from the container at a later date), reimplement the same behaviour as the v5 containers - in which the PIHOLE_DOCKER_TAG is baked into the image and stored at /pihole.docker.tag per:

RUN echo "${PIHOLE_DOCKER_TAG}" > /pihole.docker.tag


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from a team July 23, 2023 20:21
@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PromoFaux PromoFaux merged commit 4471863 into development-v6 Jul 23, 2023
18 checks passed
@PromoFaux PromoFaux deleted the v6/docker_tag branch July 23, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants