-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the FTL log tail optional. Pass in TAIL_FTL_LOG: 0
to silence it
#1385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no logs are required may be pihole-FTL could be started et kept in foreground ('-f)
If we did that, then the container would stop if ever FTL was restarted/stopped. For now at least I'd like to keep the command as-is |
8b3ff9c
to
74c4593
Compare
Kudos, SonarCloud Quality Gate passed! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Something else I realised in doing some testing this evening. I am not sure what it is, but I remember it happening on v5 container too, if we start pihole-FTL in the foreground, it stops outputting to the docker log. Note there are more lines in the actual file than there are on the bottom half of the screen: |
What is actually puzzling here is that it stops right in the middle of reporting the database statistics. They are simply a collection of https://github.com/pi-hole/FTL/blob/5753b50df40defa15d16f6989e12a9ecf3439be9/src/log.c#L502-L512 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…environment variable TAIL_FTL_LOG with a value of 0. Defaults to enabled (1) Signed-off-by: Adam Warner <[email protected]>
74c4593
to
76e09bf
Compare
Conflicts have been resolved. |
Marked conversation about init systems as outdated due to #1406 being merged. Starting FTL in the foreground leads to weirdness with the output where it just cuts out - see previous two comments. This works well enough. Either we tail the log or we don't. Simples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs documentation of the new env setting.
Co-authored-by: yubiuser <[email protected]> Signed-off-by: Adam Warner <[email protected]>
What does this PR aim to accomplish?:
See title. By default the image will tail the FTL log. Users can disable this if it is too noisy for their preference
By submitting this pull request, I confirm the following:
git rebase
)