Remove one layer by having both git clone together #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gontier Julien <[email protected]>
rdwebdesign
requested changes
Jul 15, 2023
Make it consistence with other multi-line commands. Co-authored-by: RD WebDesign <[email protected]> Signed-off-by: Snow <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
PromoFaux
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically tidy up both git clone together.
Description
Removed the second 'RUN' git clone, and add it directly after the second one.
Motivation and Context
It isn't required and doesn't solve any problem, but (maybe this is a old habit of older version) i think it always better to have less layer if possible.
And it doesn't make it less readable so i think it okay
How Has This Been Tested?
Tested and working, it shouldn't affect the container anyways.
Types of changes
Checklist: