Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPv4 address indicator #422

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Fix IPv4 address indicator #422

merged 1 commit into from
Feb 24, 2025

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Feb 23, 2025

What does this PR aim to accomplish?:

Fixes a small issue, where PADD would show the + indicator for 'more then one' IPv4 addresses being available when they are not but exactly one.

There was an elif statement commented out, because the relevant address was already set, but nevertheless the statement needed to be checked, otherwise the following else would have been triggered.


  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested review from DL6ER, rdwebdesign and a team February 23, 2025 20:44
@yubiuser yubiuser merged commit b00933f into development Feb 24, 2025
4 checks passed
@yubiuser yubiuser deleted the fix/ip branch February 24, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants