-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move wiki to readme #419
Move wiki to readme #419
Conversation
Should the Docker information be higher up? |
i will squash all these commits once it's all finished |
828baaa
to
554d548
Compare
Also as a side note I am unable to confirm if the PiTFT instructions actually work. The wiki page hasn't been updated since 2018 so there's a chance they aren't accurate. |
I'm not sure any of the developers uses such a PiTFT display. But this is something open source is good for - users can tell us if old guides don't work anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the content is fine now. I only wonder if we should undo your last changes where you put the instructions for running it on a different machine below.
Personally, I would have a but section "Using PADD" with those subsection
- Running it on the Pi-hole device
- Running it on any device in your network
- Running it on docker
- PiTFT
Last: Update PADD
I can make those adjustments and squash again |
853c059
to
969f5c8
Compare
Co-authored-by: yubiuser <[email protected]> Signed-off-by: Michael Woolweaver <[email protected]>
e928268
to
fd778f4
Compare
maybe this should have waited for #416 considering the steps given? |
Upps... I don't mind. I'm sure at some point 416 will be merged :-) If not we can easily change the Readme again. |
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Move info from Wiki to Readme. Should help with maintaining in the future. See #333
How does this PR accomplish the above?:
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase
)