Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DHCP and IPv6 info #412

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Improve DHCP and IPv6 info #412

merged 4 commits into from
Feb 13, 2025

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Improves the shown IPv6 and DHCP info.

  1. On smaller PADD sizes, the IPv6 checkbox showed the IPv6 Router advertisement status instead of the availability of an IPv6 address. I think this was misleading and the presence of IPv6 Router advertisement is less important than IPv6 'availability'
  2. Always display if Pi-hole has the DHCP server turned on/off
  3. If there was enough space, show the DHCP address range
  4. If there was enough space, show one IPv6 address

Additionally

  1. Fix the startup sequence when starting in 'mini'
  2. Clear the screen once on startup to prevent remains from the startup sequence

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team February 12, 2025 13:17
@yubiuser yubiuser merged commit f2e3f7d into development Feb 13, 2025
5 checks passed
@yubiuser yubiuser deleted the ipv6 branch February 13, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants