Change default value of webserver.threads to 50 #2305
Merged
+16
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Change default value of
webserver.threads
to 50, make 0 behave as if the user has set 50 (for backwards-compatibility reasons) and remove the upper limit we enforced on the number of threads.This should improve the webserver/API's performance especially of single- and dual-core machines.
The word of warning I have for this change can be read here: #2284 (comment) I guess we still want to do this. We also updated CivetWeb in between (and I will shortly put up another update to their current
master
), so the original issue may really have been fixed.Related issue or feature (if applicable): Fixes #2284
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.