Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of webserver.threads to 50 #2305

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 28, 2025

What does this implement/fix?

Change default value of webserver.threads to 50, make 0 behave as if the user has set 50 (for backwards-compatibility reasons) and remove the upper limit we enforced on the number of threads.

This should improve the webserver/API's performance especially of single- and dual-core machines.

The word of warning I have for this change can be read here: #2284 (comment) I guess we still want to do this. We also updated CivetWeb in between (and I will shortly put up another update to their current master), so the original issue may really have been fixed.


Related issue or feature (if applicable): Fixes #2284

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…the user has set 50 (for backwards-compatibility reasons) and remove the upper limit we enforced on the number of threads.

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER requested a review from a team February 28, 2025 16:31
@yubiuser
Copy link
Member

Did you target master on purpose?

@DL6ER DL6ER changed the base branch from master to development February 28, 2025 16:42
@DL6ER
Copy link
Member Author

DL6ER commented Feb 28, 2025

No...

@DL6ER DL6ER merged commit 548f8ea into development Mar 2, 2025
18 checks passed
@DL6ER DL6ER deleted the tweak/webserver_threads branch March 2, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow loading of pages when navigating the web UI, dnsmasq signal 17 logged to FTL.log
3 participants