Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fork shared memory access #2121

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Fix fork shared memory access #2121

merged 2 commits into from
Nov 18, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 18, 2024

What does this implement/fix?

When adding the three new shared memory objects for client, domain, and DNS cache lookup tables, we forgot to add the code ensuring they are remapped in all processes in case one process has to resize them to add further records. This resulted in TCP forks still trying to access the memory on the previous location where the object is no more present and will inevitable lead to memory corruption, possibly affecting other code regions (such as the very memory allocation intense sqlite3 library) or cause simple crashes due to trying to access non-allocated memory regions.

This PR fixes this and has been confirmed in #2112. Heavy TCP DNS activity was required to see this crash which is probably why it has neither been found during the reviewing process nor by the extensive CI testing suite.

The code in this PR has already been confirmed in #2112


Related issue or feature (if applicable): Fixes #2112

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER enabled auto-merge November 18, 2024 16:47
@DL6ER DL6ER merged commit f130216 into development Nov 18, 2024
18 checks passed
@DL6ER DL6ER deleted the fix/binsearch_shm branch November 18, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants