Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
When adding the three new shared memory objects for client, domain, and DNS cache lookup tables, we forgot to add the code ensuring they are remapped in all processes in case one process has to resize them to add further records. This resulted in TCP forks still trying to access the memory on the previous location where the object is no more present and will inevitable lead to memory corruption, possibly affecting other code regions (such as the very memory allocation intense
sqlite3
library) or cause simple crashes due to trying to access non-allocated memory regions.This PR fixes this and has been confirmed in #2112. Heavy TCP DNS activity was required to see this crash which is probably why it has neither been found during the reviewing process nor by the extensive CI testing suite.
The code in this PR has already been confirmed in #2112
Related issue or feature (if applicable): Fixes #2112
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.