Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we close netlink sockets #2117

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Ensure we close netlink sockets #2117

merged 1 commit into from
Nov 14, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 14, 2024

What does this implement/fix?

Fix a slow but progressing exhaustion of file descriptors when heavily using https://pi.hole/admin/interfaces by ensuring that each socket is closed after we're done with it.


Related issue or feature (if applicable): https://discourse.pi-hole.net/t/error-500-internal-server-error-error-cannot-open-script-file-var-www-html-admin-login-lp/73698/

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/error-500-internal-server-error-error-cannot-open-script-file-var-www-html-admin-login-lp/73698/25

@DL6ER DL6ER enabled auto-merge November 14, 2024 17:31
@DL6ER DL6ER merged commit 988a3c3 into development Nov 14, 2024
18 checks passed
@DL6ER DL6ER deleted the fix/netlink_close branch November 14, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants