Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve QPS calculation #2076

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Improve QPS calculation #2076

wants to merge 2 commits into from

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 2, 2024

What does this implement/fix?

Outsource counter resetting into a dedicated function periodically run by the GC thread to make the average computation independent from external trigger sources. This solves the problem of artificially high QPS values when no queries are processed by FTL.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…n by the GC thread to make the average computation independet from external trigger sources. This solves the problem of artificially high QPS values when no queries are processed by FTL.

Signed-off-by: DL6ER <[email protected]>
@yubiuser
Copy link
Member

yubiuser commented Oct 3, 2024

It seems the counter is not updated every second. It stays the same sometimes for a longer time but suddenly starts changing every second and then a longer interval occurs again.

Peek 2024-10-03 10-56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants