Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track and prioritize routing according to application restart generations #2564

Merged
merged 36 commits into from
Nov 21, 2024

Conversation

CamJN
Copy link
Member

@CamJN CamJN commented Sep 9, 2024

The generation number groups all application processes according to the most recent restart initiation. We use this information to intelligently route to newer generations if there is capacity.

Fixes one aspect of #2551.

@CamJN CamJN requested a review from FooBarWidget September 9, 2024 18:49
@CamJN CamJN self-assigned this Sep 9, 2024
@CamJN CamJN added this to the 6.0.24 milestone Sep 9, 2024
@FooBarWidget FooBarWidget changed the title app generations feature Track application restart generations Sep 17, 2024
@CamJN CamJN force-pushed the feature/app_generations branch from 48f430d to 187b804 Compare September 22, 2024 21:04
not that there’s a point in this test really
@CamJN CamJN force-pushed the feature/app_generations branch from 187b804 to a376e8e Compare September 23, 2024 20:59
@CamJN CamJN force-pushed the feature/app_generations branch from 4a9b0ed to 6b739f3 Compare September 30, 2024 04:41
src/agent/Core/ApplicationPool/Process.h Outdated Show resolved Hide resolved
src/agent/Core/ApplicationPool/Process.h Outdated Show resolved Hide resolved
test/cxx/Core/ApplicationPool/PoolTest.cpp Outdated Show resolved Hide resolved
test/cxx/Core/ApplicationPool/PoolTest.cpp Show resolved Hide resolved
test/cxx/Core/ApplicationPool/ProcessTest.cpp Show resolved Hide resolved
test/cxx/Core/ApplicationPool/ProcessTest.cpp Outdated Show resolved Hide resolved
@FooBarWidget FooBarWidget force-pushed the feature/app_generations branch from 899ac69 to 6ab1b52 Compare October 3, 2024 14:55
@CamJN CamJN force-pushed the feature/app_generations branch from 80604b6 to b40c7d2 Compare October 14, 2024 20:36
@CamJN CamJN force-pushed the feature/app_generations branch from 5d9e371 to 8a5ebc3 Compare November 11, 2024 16:23
@CamJN
Copy link
Member Author

CamJN commented Nov 11, 2024

The tests that failed in the last run were due to the cache step failing, I reran them and they passed.

@CamJN
Copy link
Member Author

CamJN commented Nov 11, 2024

All requested changes have been made.

@FooBarWidget FooBarWidget changed the title Track application restart generations Track and prioritize routing according to application restart generations Nov 21, 2024
@FooBarWidget FooBarWidget merged commit 2a6c035 into stable-6.0 Nov 21, 2024
@FooBarWidget FooBarWidget deleted the feature/app_generations branch November 21, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passenger Enterprise zero-downtime restarts & request routing can prolong outages and delay recovery
2 participants