Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add Java test [TSI-2113] #420

Merged
merged 6 commits into from
Oct 11, 2023
Merged

test: Add Java test [TSI-2113] #420

merged 6 commits into from
Oct 11, 2023

Conversation

jablan
Copy link
Collaborator

@jablan jablan commented Oct 10, 2023

Adds basic test for Java library
https://phrase.atlassian.net/browse/TSI-2113

@jablan jablan marked this pull request as ready for review October 11, 2023 09:10
@jablan
Copy link
Collaborator Author

jablan commented Oct 11, 2023

@theSoenke I was looking into moving .gitignore chunks into appropriate subdirectories, but they already contain generated .gitignore files, so we'd have to customize corresponding mustache templates, which felt a bit wrong. also, having all these in a single place makes more sense IMO.

@jablan jablan requested a review from theSoenke October 11, 2023 09:12
theSoenke
theSoenke approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@theSoenke theSoenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, another one done

@jablan jablan merged commit ca1f575 into master Oct 11, 2023
6 checks passed
@jablan jablan deleted the tsi-2113-add-java-test branch October 11, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theSoenke theSoenke theSoenke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jablan @theSoenke