Fix always-true detection in in_array with union type haystack #3888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your PR has impact on more open bugs. please look at the changes and decide whether these are correct/intended please add additional tests to cover this bugs, in case they are fixed |
staabm
reviewed
Mar 19, 2025
Comment on lines
22
to
41
| /** | ||
| * @param array{ | ||
| * key1: ?bool, | ||
| * } $myArray | ||
| */ | ||
| public function testBool(array $myArray): ?\stdClass | ||
| { | ||
| if (\in_array(null, $myArray, true)) { | ||
| return null; | ||
| } | ||
|
|
||
| return (object) $myArray; | ||
| } |
There was a problem hiding this comment.
you should test a case which is expected to still emit an error after the change (a array which always contains null)
ondrejmirtes
requested changes
May 5, 2025
| @@ -147,7 +147,7 @@ public function findSpecifiedType( | |||
| foreach ($haystackArrayTypes as $haystackArrayType) { | |||
| if ($haystackArrayType instanceof ConstantArrayType) { | |||
| foreach ($haystackArrayType->getValueTypes() as $i => $haystackArrayValueType) { | |||
| if ($haystackArrayType->isOptionalKey($i)) { | |||
| if ($haystackArrayValueType instanceof UnionType || $haystackArrayType->isOptionalKey($i)) { | |||
There was a problem hiding this comment.
I believe there's a better way to ask this. Something like count($haystackArrayValueType->getFiniteTypes()) === 1.
|
Please fix the conflicts. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve phpstan/phpstan#12755