Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of enum default values with PHP 8.1 #618

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

jdreesen
Copy link
Contributor

Fixes #567

The problem is, that the generated default value is in the wrong namespace, because the leading \ is missing.

This seems only to be a problem in PHP 8.1, see: https://3v4l.org/3JPCM

@jdreesen
Copy link
Contributor Author

CI failure is unrelated.

@stof stof merged commit f9e07be into phpspec:master Mar 29, 2024
8 of 9 checks passed
@jdreesen jdreesen deleted the patch-1 branch March 29, 2024 12:08
@jdreesen
Copy link
Contributor Author

jdreesen commented Jun 6, 2024

Would it be possible to get a release with this fix?

@stof stof added the PHP8.1 label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method with an enum argument and default value can't be mocked
2 participants