This repository was archived by the owner on Oct 5, 2022. It is now read-only.
Update Pdo.php #129
Open
Update Pdo.php #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to provide an already existing connection instead of forcing a new one to be created for phpsec.
| private $psl = null; | ||
|
|
||
| public function __construct($loc, \phpSec\Core $psl, \PDO $dbh = null, $table = null) { |
There was a problem hiding this comment.
Why does $loc remain unused and does this constructor introduce a new parameter $table?
Perhaps it's better to pass the table name through $loc as normal and make the third param in the constructor dual purpose (either additional connection options, or existing PDO instance). This would be more future-feature compatible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to provide an already existing connection instead of forcing a new one to be created for phpsec. The only thing I changed was the constructor, but for some reason github thinks I changed the whole file. I'm assuming it's an indentation issue. I'm new to github and I don't know how to edit this thing, so maybe someone else could just copy and paste the changed lines from the constructor if you feel it's useful.