Components refactoring #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
============================================
+ Coverage 96.20% 96.54% +0.33%
+ Complexity 2162 2147 -15
============================================
Files 64 73 +9
Lines 5032 5006 -26
============================================
- Hits 4841 4833 -8
+ Misses 191 173 -18 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]> c
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
MauricioFauth
approved these changes
Jan 20, 2024
kamil-tekiela
force-pushed
the
Components-refactoring
branch
from
891d9ff to
33e49e6
Compare
Thanks. I rebased it. I am wondering if I should move all |
This is a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My idea here is to tidy this all up by splitting the
staticfunctionality from the value objects. But the ultimate goal is to fix the instantiation of all Component objects, which this PR doesn't really help with. I consider this to be a good change nonetheless.