Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #520

Merged
merged 12 commits into from
Jan 12, 2024
Merged

Minor fixes #520

merged 12 commits into from
Jan 12, 2024

Conversation

kamil-tekiela
Copy link
Contributor

Based on #519

Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
It looks like this function is not used anywhere so this probably doesn't require any other amendments.

Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7da0f9b) 96.43% compared to head (a40efe4) 96.45%.
Report is 3 commits behind head on master.

Files Patch % Lines
src/Lexer.php 80.00% 1 Missing ⚠️
src/Parser.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #520      +/-   ##
============================================
+ Coverage     96.43%   96.45%   +0.01%     
+ Complexity     2152     2150       -2     
============================================
  Files            65       64       -1     
  Lines          5024     5015       -9     
============================================
- Hits           4845     4837       -8     
+ Misses          179      178       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kamil Tekiela <[email protected]>
@MauricioFauth MauricioFauth merged commit 25a0713 into phpmyadmin:master Jan 12, 2024
11 of 12 checks passed
@MauricioFauth MauricioFauth self-assigned this Jan 12, 2024
@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Jan 12, 2024
@kamil-tekiela kamil-tekiela deleted the Minor-fixes branch January 12, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants