Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code is now compatible with PHP8 #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Bal2018
Copy link
Member

@Bal2018 Bal2018 commented Mar 12, 2021

Feature/ Issue Description

Code was giving issues with using php 8 on my local when the packages initially installed were for php 7.4.
The final issue I came across was Script security-checker security:check returned with error code 1.
Discovered that "symfony/(recently) got rid of its security package and so had to uninstall this.

Code Explanation

Updated :

 composer update infection/infection --with-dependencies
 composer update doctrine/orm

And uninstalled :
composer remove sensiolabs/security-checker

In the code base updated .env file to include app path and correct port number

@@ -2,7 +2,7 @@
"type": "project",
"license": "proprietary",
"require": {
"php": "^7.4",
"php": "^7.4|^8.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bal2018 can you update this to be "^7.4 || ^8.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants