Add PHP 8.4 tests support

.github/workflows/main.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: [ '7.4', '8.0', '8.1', '8.2', '8.3' ]
+        php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
         os: [ ubuntu-latest, macos-latest, windows-latest ]
         stability: [ prefer-lowest, prefer-stable ]
     steps:

src/Executor.php

@@ -188,6 +188,7 @@ private function each(iterable $nodes): iterable
      * Recursively traverse array (usually of nodes).
      *
      * @param array<array-key, object> $nodes Array to traverse
+     *
      * @return array<array-key, object> Result of traversal. May be original
      *         array or changed one.
      */
@@ -229,7 +230,6 @@ protected function traverseArray(array $nodes): array
                             $error = \sprintf($error, \get_class($visitor), \gettype($visitor));
 
                             throw new BadMethodException($error, static::ERROR_CODE_ARRAY_ENTERING);
-
                         default:
                             $error = self::ERROR_ENTER_RETURN_TYPE;
                             $error = \sprintf($error, \get_class($visitor), \gettype($visitor));
@@ -297,7 +297,8 @@ protected function traverseArray(array $nodes): array
     /**
      * Recursively traverse a node.
      *
-     * @param NodeInterface $node NodeInterface to traverse.
+     * @param NodeInterface $node nodeInterface to traverse
+     *
      * @return NodeInterface Result of traversal (may be original node or new one)
      */
     protected function traverseNode(NodeInterface $node): NodeInterface
@@ -375,7 +376,6 @@ protected function traverseNode(NodeInterface $node): NodeInterface
                                 $error = \sprintf($error, \get_class($visitor));
 
                                 throw new BadReturnTypeException($error, static::ERROR_CODE_NODE_LEAVING);
-
                             default:
                                 $error = self::ERROR_LEAVE_RETURN_TYPE;
                                 $error = \sprintf($error, \get_class($visitor), \gettype($return));
@@ -396,7 +396,6 @@ protected function traverseNode(NodeInterface $node): NodeInterface
 
     /**
      * @param string|int $key
-     * @param mixed $value
      */
     private function updateNodeValue(NodeInterface $node, $key, $value): void
     {

src/ExecutorInterface.php

@@ -9,7 +9,7 @@ interface ExecutorInterface
     /**
      * Traverses an array of nodes using the registered visitors.
      *
-     * @param iterable<array-key, object> $nodes List of nodes.
+     * @param iterable<array-key, object> $nodes list of nodes
      *
      * @return iterable<array-key, object> Traversed list of nodes
      */

src/Traverser.php

@@ -44,8 +44,6 @@
 
 namespace Phplrt\Visitor;
 
-use Phplrt\Contracts\Ast\NodeInterface;
-
 class Traverser implements TraverserInterface
 {
     /**

src/TraverserInterface.php

@@ -4,8 +4,6 @@
 
 namespace Phplrt\Visitor;
 
-use Phplrt\Contracts\Ast\NodeInterface;
-
 /**
  * The TraverserInterface allows to traverse groups of
  * nodes using visitor sets.
@@ -75,6 +73,7 @@ public function without(VisitorInterface $visitor): self;
      * registered visitors.
      *
      * @param iterable<array-key, object> $nodes
+     *
      * @return iterable<array-key, object>
      */
     public function traverse(iterable $nodes): iterable;

src/VisitorInterface.php

@@ -12,28 +12,26 @@ interface VisitorInterface
      * Called once before traversal.
      *
      * @param iterable|NodeInterface[]|NodeInterface $nodes
+     *
      * @return iterable|NodeInterface[]|NodeInterface|null
      */
     public function before(iterable $nodes): ?iterable;
 
     /**
      * Called when entering a node.
-     *
-     * @return mixed
      */
     public function enter(NodeInterface $node);
 
     /**
      * Called when leaving a node.
-     *
-     * @return mixed
      */
     public function leave(NodeInterface $node);
 
     /**
      * Called once after traversal.
      *
      * @param iterable|NodeInterface[]|NodeInterface $nodes
+     *
      * @return iterable|NodeInterface[]|NodeInterface|null
      */
     public function after(iterable $nodes): ?iterable;

tests/Unit/Mutations/BeforeTraversingMutationsTest.php

@@ -7,7 +7,6 @@
 use Phplrt\Visitor\Tests\Unit\Stub\Node;
 use Phplrt\Visitor\Tests\Unit\TestCase;
 use Phplrt\Visitor\Visitor;
-use PHPUnit\Framework\ExpectationFailedException;
 
 /**
  * @testdox A set of tests that verify an AST modification using the Visitor::before() method.

tests/Unit/Mutations/EnteringMutationsTest.php

@@ -10,7 +10,6 @@
 use Phplrt\Visitor\Tests\Unit\Stub\Node;
 use Phplrt\Visitor\Tests\Unit\TestCase;
 use Phplrt\Visitor\Visitor;
-use PHPUnit\Framework\ExpectationFailedException;
 
 /**
  * @testdox A set of tests that verify an AST modification using the Visitor::enter() method.

tests/Unit/Mutations/LeavingMutationsTest.php

@@ -9,7 +9,6 @@
 use Phplrt\Visitor\Tests\Unit\Stub\Node;
 use Phplrt\Visitor\Tests\Unit\TestCase;
 use Phplrt\Visitor\Visitor;
-use PHPUnit\Framework\ExpectationFailedException;
 
 /**
  * @testdox A set of tests that verify an AST modification using the Visitor::leave() method.

tests/Unit/Stub/Counter.php

@@ -10,9 +10,9 @@
 class Counter implements VisitorInterface
 {
     public $before = 0;
-    public $after  = 0;
-    public $enter  = 0;
-    public $leave  = 0;
+    public $after = 0;
+    public $enter = 0;
+    public $leave = 0;
 
     public function before(iterable $nodes): ?iterable
     {

tests/Unit/Stub/Node.php

@@ -13,24 +13,14 @@ class Node implements NodeInterface
      */
     public array $children;
 
-    /**
-     * @var int
-     */
     private int $id;
 
-    /**
-     * @param int $id
-     * @param array $children
-     */
     public function __construct(int $id, array $children = [])
     {
         $this->id = $id;
         $this->children = $children;
     }
 
-    /**
-     * @return int
-     */
     public function getId(): int
     {
         return $this->id;
@@ -44,9 +34,6 @@ public function getIterator(): \Traversable
         return new \ArrayIterator(['children' => $this->children]);
     }
 
-    /**
-     * @return int
-     */
     public function getOffset(): int
     {
         return 0;

tests/Unit/TraversableTest.php

@@ -5,7 +5,6 @@
 namespace Phplrt\Visitor\Tests\Unit;
 
 use Phplrt\Visitor\Tests\Unit\Stub\Counter;
-use PHPUnit\Framework\ExpectationFailedException;
 
 /**
  * @testdox A set of tests that count the number of passes by nodes.

tests/Unit/VisitorsTest.php

@@ -6,7 +6,6 @@
 
 use Phplrt\Visitor\Tests\Unit\Stub\Counter;
 use Phplrt\Visitor\Traverser;
-use PHPUnit\Framework\ExpectationFailedException;
 
 /**
  * @testdox A set of tests that check the interaction of Visitor instances with the Traversable container.