Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Run vimeo/psalm on GitHub Actions #892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Dec 8, 2023

This pull request

  • runs a static code analysis with vimeo/psalm on GitHub Actions

Follows #559.

@localheinz localheinz force-pushed the feature/static-code-analysis branch 5 times, most recently from f191e83 to 799a830 Compare December 8, 2023 09:42
.gitignore Outdated Show resolved Hide resolved
psalm.xml Outdated Show resolved Hide resolved
@kamil-tekiela
Copy link
Member

Given that we have very little test coverage (and are currently unable to name it), using a tool to run a static code analysis can improve our confidence in the changes we make.

That would help, but not by much. For me the biggest problem in this project is the interdependency with other repos and who knows what else. It's a jungle. There are scripts that call other scripts, execute functions, include files and more. This makes it difficult to refactor anything, because we don't know what has an impact on what.

psalm.xml Outdated Show resolved Hide resolved
@localheinz localheinz force-pushed the feature/static-code-analysis branch 2 times, most recently from d8f7636 to 83d6298 Compare February 1, 2024 08:52
Copy link

github-actions bot commented Feb 1, 2024

🚀 Commit db5ec41 Deployed on https://web-php-pr-892.preview.thephp.foundation

@localheinz localheinz marked this pull request as ready for review February 1, 2024 08:53
@localheinz localheinz closed this Feb 12, 2024
@localheinz localheinz deleted the feature/static-code-analysis branch February 12, 2024 17:00
@localheinz localheinz restored the feature/static-code-analysis branch February 17, 2024 14:48
@localheinz localheinz reopened this Feb 17, 2024
@localheinz localheinz force-pushed the feature/static-code-analysis branch 2 times, most recently from 51506d3 to 6dd04ff Compare February 17, 2024 14:51
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@42e335e). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##             master    #892   +/-   ##
========================================
  Coverage          ?   0.14%           
  Complexity        ?      45           
========================================
  Files             ?      49           
  Lines             ?   43151           
  Branches          ?       0           
========================================
  Hits              ?      64           
  Misses            ?   43087           
  Partials          ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz force-pushed the feature/static-code-analysis branch 3 times, most recently from e835d79 to f467fce Compare February 17, 2024 14:53
@localheinz localheinz force-pushed the feature/static-code-analysis branch 11 times, most recently from e0bfb53 to 17f20f5 Compare February 18, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants