ext/readline: fix global readline vars when updating rl_line_buffer. #15120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
readline_info_upd
branch
from
4e2363c to
e3cde84
Compare
if the new value was larger, rl_line_buffer_length was never updated. neither was rl_end (on unixes).
devnexen
force-pushed
the
readline_info_upd
branch
from
e3cde84 to
4335e31
Compare
Girgias
reviewed
Jul 27, 2024
ext/readline/readline.c
Outdated
| if (strlen(oldstr) < Z_STRLEN_P(value)) { | ||
| rl_extend_line_buffer(Z_STRLEN_P(value) + 1); | ||
| } | ||
| strcpy(rl_line_buffer, Z_STRVAL_P(value)); |
There was a problem hiding this comment.
Why not memcpy? We already checked that the buffer is large enough
There was a problem hiding this comment.
that s the thing, since we know it s large enough strcpy fits by its simplicity :)
There was a problem hiding this comment.
after 2nd thoughts, will give it a try.
devnexen
force-pushed
the
readline_info_upd
branch
from
fe185fb to
f472621
Compare
|
@remicollet just reported that this broke libedit builds. Maybe somebody wants to have a look at this. And it might be a good idea to run at least one CI against libedit-dev instead of libreadline-dev. |
|
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the new value was larger, rl_line_buffer_length was never updated. neither was rl_end (on unixes).