Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constants link broken #88

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Fix constants link broken #88

merged 1 commit into from
Nov 12, 2023

Conversation

sy-records
Copy link
Member

Fix #87

image

btw, there seems to be a problem with all the <row xml:id links.

e,g. https://www.php.net/manual/en/tokens.php

The __TRAIT__ link is the current page and is correct after the fix.

image

Sorry, I committed to master by mistake. 😅 934be12

@sy-records sy-records requested review from Girgias and cmb69 November 10, 2023 08:42
@sy-records sy-records changed the title Fix missing constants link Fix constants link broken Nov 10, 2023
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, but I'm confused why we don't just index on all rows?

@sy-records
Copy link
Member Author

yep, I'm not sure why it wasn't there before, but now it is.
image

@Girgias Girgias merged commit bacc87c into php:master Nov 12, 2023
@sy-records sy-records deleted the fix/constants branch November 12, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links for constants in table rows
2 participants