Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum PHP version to 8.1 #169

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

kamil-tekiela
Copy link
Member

The code uses the never type which was introduced in PHP 8.1 so we need to bump the minimum version.

@kamil-tekiela kamil-tekiela requested a review from cmb69 October 22, 2024 21:39
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping the version is okay for me, but an alternative could be to remove the never return type (could be an annotation instead).

And we should probably use some tooling which can detect such issues.

@kamil-tekiela
Copy link
Member Author

Bumping the version is okay for me, but an alternative could be to remove the never return type (could be an annotation instead).

And we should probably use some tooling which can detect such issues.

PHP 8.1 is pretty old by now so I feel dropping the support is better. If I find something from PHP 8.2, I will do that.

@kamil-tekiela kamil-tekiela merged commit ec49154 into php:master Oct 22, 2024
9 checks passed
@kamil-tekiela kamil-tekiela deleted the PHP-8.1 branch October 22, 2024 22:04
@derickr
Copy link
Member

derickr commented Oct 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants