Fix element map so changelog rows are handled correctly

[jimwins]

https://www.php.net/manual/en/doc.changelog.php is empty because this was backwards and changelog entries weren't actually being indexed.

[cmb69]

Hmm, wouldn't that revert bacc87c? @sy-records can you check?

[jimwins]

Yeah, I'm really not quite sure what is going here. Without my change, format_row() never gets called so nothing is added to the $this->changelog array. But with the change, some things in rows don't get properly linked.

Looks like we have one map that is trying to handle <tbody><row><entry> and another just <tbody><row> and things are getting confused. format_entry() is treating $this->currentChangelog as an array of strings, format_row() treats it as an array containing of the membership and id?

[jimwins]

Okay, figured out how to solve the issue. When format_row() was actually being used, the id was no longer being saved, among other things. Now it does what it needs to do and falls through to UNDEF() so that does what it needs to do.

With this the changelog is rendered and the other things shouldn't change.

The sorting/grouping of the changelog is less than ideal because a change across multiple versions ("8.0.21, 8.1.8, 8.2.0", for example) will get sorted only with that first version number.

What we could do is when saving things to the changelogs table in phpdotnet/phd/IndexRepository.php, split the version and save N copies of that entry so it can then appear with each specific version. We can toss irregular versions because those will be for PECL and we don't include that in the generated changelog. That's going to make the changelog even more huge, though. (The XHTML version right now is about 317K.)

[sy-records]

I tested it.

LGTM.

[jimwins]

Pushed a change to the PR to do that version splitting. Together with the cleanup in php/doc-en#3672, this results in a doc.changelog.html that is 329K, but that includes changes since 5.0.0. Changing it to 8.0.0 takes it down to 274K. (This is configured in doc-base/manual.xml/in.)

[cmb69]

[…], but that includes changes since 5.0.0.

Actually, the current documentation shouldn't care about PHP 5 anymore.

[jimwins]

Opened php/doc-base#146 to bump up it up to 7.0.0. That shaves off ~8K.

[haszi]

Could you also add a test showing how the changelog entries are now indexed and another one that shows that whatever was not properly linked after the first commit is now being linked correctly?

[jimwins]

Will merge this once php/doc-en#3672 is approved and merged, I'd rather not merge this and end up with the messy changelog that results without those cleanups.