Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocBook 5.2 class and exception markup migration #134

Merged

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Jun 2, 2024

This PR adds support for the new markup for classes and exceptions. Rendering doc-en with the old markup with and without these changes, and the new markup with these changes showed zero diffs.

haszi added 4 commits June 2, 2024 11:19
Add rendering support for new class and exception markup in the PHP package.
Add tests for the old and the new class and exception markup.
…new markup

When a reference element has the appropriate roles, store the name of the current class or exception. If this is not done, PhD will generate links to the class even from the class's own synopsis page.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delegating to the existing way is actually smart!

LGTM but could you add the tests I mentionned? :)

@haszi haszi requested a review from Girgias June 3, 2024 20:44
@Girgias Girgias merged commit ef44b90 into php:master Jun 3, 2024
9 checks passed
@haszi haszi deleted the DocBook-5.2-class-and-exception-markup-migration branch June 4, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants