Move all database access to IndexRepository #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all database access to IndexRepository.
Use the same database during the entire indexing-rendering process.
Add a simple smoke test for render.php.
This PR is the same as #120 with the following exceptions:
functions.php
'srequireIndexing()
is now checking whetherConfig
'sindexcache
exists (where the indexing database used everywhere is stored in and after this PR), therefore theSQLite
database parameter has been removedindexcache
is set for every run so setting it after indexing has been removed inrender.php
$config
parameter (of typeConfig
) tomake_reader()
inrender.php
, calling it withnew Config
arguments at call sites (this was the issue that broke the builds in the last PR, thanks to @sy-records for pointing it out)render.php
so that the last PR's issues can be caught immediately in a local dev environment too