Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all database access to IndexRepository #126

Merged
merged 1 commit into from
May 20, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented May 14, 2024

Move all database access to IndexRepository.
Use the same database during the entire indexing-rendering process.
Add a simple smoke test for render.php.

This PR is the same as #120 with the following exceptions:

  • functions.php's requireIndexing() is now checking whether Config's indexcache exists (where the indexing database used everywhere is stored in and after this PR), therefore the SQLite database parameter has been removed
  • indexcache is set for every run so setting it after indexing has been removed in render.php
  • added the $config parameter (of type Config) to make_reader() in render.php, calling it with new Config arguments at call sites (this was the issue that broke the builds in the last PR, thanks to @sy-records for pointing it out)
  • added a smoke test for render.php so that the last PR's issues can be caught immediately in a local dev environment too

Move all database access to IndexRepository.
Use the same database during the entire indexing-rendering process.
Add a simple smoke test for render.php.
@Girgias Girgias merged commit fc84db4 into php:master May 20, 2024
9 checks passed
@Girgias
Copy link
Member

Girgias commented May 20, 2024

Hopefully this works this time :D

@haszi haszi deleted the Move-database-access-to-IndexRepository branch May 20, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants