Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Update README about PHP 8.4 and why this repository exists #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gido
Copy link

@gido gido commented Jul 8, 2024

Following a discussion in issue #4

@@ -2,6 +2,9 @@

Use the PDO_OCI extension to access Oracle Database.

This repository is for PHP 8.4+ as it [was decided to unbundle](https://wiki.php.net/rfc/unbundle_imap_pspell_oci8) PDO OCI / OCI8 extension from the PHP source code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it builds on 8.3, can you update the versions mentioned?

@@ -2,6 +2,9 @@

Use the PDO_OCI extension to access Oracle Database.

This repository is for PHP 8.4+ as it [was decided to unbundle](https://wiki.php.net/rfc/unbundle_imap_pspell_oci8) PDO OCI / OCI8 extension from the PHP source code.
You can find the extension for PHP 8.3 (and previous) [here](https://github.com/php/php-src/tree/PHP-8.3/ext/pdo_oci).

Documentation is at https://www.php.net/pdo_oci

Use `pecl install pdo_oci` to install for PHP 8.2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be completely outdated, since there have been no PECL releases for almost 20 years. Are there any plans regarding a new release? At least the RFC about unbundling pdo_oci states:

The proposal is to unbundle them: remove them from the PHP source distribution, move them to PECL, and create an initial release for them.

/cc @derickr

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll get to it when I next have time; I will merge the test PR as is, and do some testing, and do a release.

Lack of PECL releases was not specific to PDO_OCI. E.g https://pecl.php.net/package/pdo, https://pecl.php.net/package/pdo_mysql both haven't had releases. Back in the day it was decided (or became true) that there was a tight coupling between the vendor layer and the generic layer, and no releases were made on PECL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, PDO and pdo_mysql are still bundled with php-src, so there is no need to have new releases. But since pdo_oci has been unbundled, it would make sense to re-activate the PECL page. At least for Windows users that would be helpful, to be able to download pre-built DLLs.

I'll try to come up with a PR regarding building (and testing) on CI (for Windows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants