Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.4] Mention PHP_HISTFILE env var の翻訳 #239

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[PHP 8.4] Mention PHP_HISTFILE env var の翻訳 #239

merged 1 commit into from
Jan 9, 2025

Conversation

nsfisis
Copy link
Contributor

@nsfisis nsfisis commented Jan 8, 2025

ref: #150

以下の英語版の更新を取り込み、翻訳しました。

こちらの文言の追加です。

As of PHP 8.4.0, the path to the history file can be set using the
<envar>PHP_HISTFILE</envar> environment variable.

youkidearitai
youkidearitai approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@youkidearitai youkidearitai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます！

@youkidearitai youkidearitai merged commit 0c82f2c into php:master Jan 9, 2025
1 check passed
@nsfisis nsfisis deleted the feature/php-histfile-env-var branch January 11, 2025 02:11
@KentarouTakeda KentarouTakeda mentioned this pull request Jan 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkidearitai youkidearitai youkidearitai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsfisis @youkidearitai